CnPack Forum


 
Subject: Bug in cnDebug.pas TraceObjectWithTag/LogObjectWithTag
MrOuzo
新警察
Rank: 1



UID 41314
Digest Posts 0
Credits 14
Posts 4
点点分 14
Reading Access 10
Registered 2008-11-20
Status Offline
Post at 2020-3-25 17:40  Profile | Blog | P.M. 
Bug in cnDebug.pas TraceObjectWithTag/LogObjectWithTag

Hello,

i think there is a bug in TraceObjectWithTag/LogObjectWithTag, the ATag is not evaluated

procedure TCnDebugger.TraceObjectWithTag(AObject: TObject;
  const ATag: string);
{$IFNDEF NDEBUG}
var
  List: TStringList;
  Intfs: string;
{$ENDIF}
begin
{$IFNDEF NDEBUG}
  List := nil;
  try
    List := TStringList.Create;
    try
      AddObjectToStringList(AObject, List, 0);
      Intfs := FormatObjectInterface(AObject);
      if Intfs <> '' then
      begin
        List.Add('Supports Interfaces:');
        List.Add(Intfs);
      end;
    except
      List.Add(SCnObjException);
    end;
    TraceMsgWithType('Object: ' + IntToHex(Integer(AObject), CN_HEX_DIGITS) + SCnCRLF +
      List.Text, cmtObject);
  finally
    List.Free;
  end;
{$ENDIF}
end;

i think the new code is

procedure TCnDebugger.TraceObjectWithTag(AObject: TObject;
  const ATag: string);
{$IFNDEF NDEBUG}
var
  List: TStringList;
  Intfs: string;
{$ENDIF}
begin
{$IFNDEF NDEBUG}
  List := nil;
  try
    List := TStringList.Create;
    try
      AddObjectToStringList(AObject, List, 0);
      Intfs := FormatObjectInterface(AObject);
      if Intfs <> '' then
      begin
        List.Add('Supports Interfaces:');
        List.Add(Intfs);
      end;
    except
      List.Add(SCnObjException);
    end;
    TraceMsgWithTypeTag('Object: ' + IntToHex(Integer(AObject), CN_HEX_DIGITS) + SCnCRLF +
      List.Text, cmtObject, ATag);    // <----- here
  finally
    List.Free;
  end;
{$ENDIF}
end;

Top
Passion (LiuXiao)
管理员
Rank: 9Rank: 9Rank: 9


UID 359
Digest Posts 19
Credits 6614
Posts 3486
点点分 6614
Reading Access 102
Registered 2004-3-28
Status Offline
Post at 2020-6-2 14:09  Profile | Blog | P.M. 
Oh, thanks for the bug report.

Now I fix it.
Top
 




All times are GMT++8, the time now is 2020-10-29 19:02

    本论坛支付平台由支付宝提供
携手打造安全诚信的交易社区 Powered by Discuz! 5.0.0  © 2001-2006 Comsenz Inc.
Processed in 0.017576 second(s), 8 queries , Gzip enabled

Clear Cookies - Contact Us - CnPack Website - Archiver - WAP